Ameerul / P2PS-464 [FE] - Mandatory Mobile Number Verification for Deriv P2P (New User) #400
Conversation
ameerul-deriv
requested review from
ali-hosseini-deriv,
yashim-deriv,
azmib-developer and
farrah-deriv
as code owners
| pathname: location.pathname, | ||
| search: searchParams.toString(), | ||
| }); | ||
| searchParams.set('verified', 'false'); |
There was a problem hiding this comment.
updated the param name to make it more general since now we're also checking for PNV if enabled
There was a problem hiding this comment.
just a question. why do we keep this in the URL params? I mean it can be easily manipulated by the user.
can we add a hook and check this in component level using that hook? 🤔
| error => | ||
| error.code === ERROR_CODES.PERMISSION_DENIED || | ||
| error.code === ERROR_CODES.INVALID_ADVERTISER_ID || | ||
| error.code === ERROR_CODES.ADVERTISER_NOT_REGISTERED |
There was a problem hiding this comment.
check for this edge case when user is not verified
|
|
||
| // create new response for poi/poa statuses | ||
| const modifiedAccountStatus = useMemo(() => { | ||
| if (!data) return undefined; | ||
|
|
||
| const documentStatus = data?.authentication?.document?.status; | ||
| const identityStatus = data?.authentication?.identity?.status; | ||
| const isP2PPoaRequired = data?.p2p_poa_required; | ||
| const isP2PPoaRequired = !!p2pSettings?.poa_required; |
There was a problem hiding this comment.
BE had informed me they will be deleting p2p_poa_required in get_account_status so they added it to p2p_settings now under poa_required
| pathname: location.pathname, | ||
| search: searchParams.toString(), | ||
| }); | ||
| searchParams.set('verified', 'false'); |
There was a problem hiding this comment.
just a question. why do we keep this in the URL params? I mean it can be easily manipulated by the user.
can we add a hook and check this in component level using that hook? 🤔
| ? [ | ||
| { | ||
| onClick: () => { | ||
| window.location.href = `${URLConstants.derivAppProduction}/account/personal-details`; |
There was a problem hiding this comment.
can we do the redirection based on the environment.. if test link or staging, redirect to staging-app.deriv. else app.deriv ?
There was a problem hiding this comment.
hmmm i dont think its necessary tbh, because either way we can still test the PNV using just prod link. Also even if we use staging and so forth, QA still need to set up the endpoint again
|
Preview Link: https://P2PS-464-mandatory-m.p2p-standalone.pages.dev
|
P2PS-464.Redirect.to.personal.details.mov